-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create RCP10 #17
base: master
Are you sure you want to change the base?
Create RCP10 #17
Conversation
`CONFIG DIFF`: Returns a list of config directives which are not the defaults. | ||
Other than returning just the changed values it should behave and repsond like | ||
a `CONFIG GET *` would. | ||
`CONFIG GET DEFAULTS`: Returns all the *default* values for all config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONFIG GETDEFAULT parameter
could be a better alternative as it follows the idea behindCONFIG GET parameter
IMHO- 👍 for
CONFIG DIFF
though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONFIG GETDEFAULT
would allow for pattern matching, CONFIG GETDEFAULT *
thus would be the same as CONFIG GET DEFAULTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good points, but I don't like munging words together, especially as it confuses people when explaining or walking them through something verbally. How about CONFIG DEFAULTS
instead? Then we could still do CONFIG DEFAULTS <pattern>
for matching.
Solid and helpful suggestion IMO 👍 Another direction for exploring this is to have each config entry have "fields", and then extend the
The additional
This would, however, require changing the RCP's gist to adding new modifiers to the existing subcommand instead of adding two new ones. |
@itamarhaber I initially thought about modifying the config get command. But this seems a much simpler route in terms if implementation as well as not overloading the config command. ;) I do like the timestamp idea for determining when a value was changed. However, alternatively I'd rather see all |
spelling...
more spelling... how tired was I when I wrote this? ;)
An RCP to add two new sub-commands to
CONFIG
for better admin and issue reporting capabilities. This fulfills issue #16