Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard session uses hash implementation #191

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

justin-cechmanek
Copy link
Collaborator

@justin-cechmanek justin-cechmanek commented Jul 29, 2024

Replaces the list implementation of Standard Session Manager to use a hash implementation.

@justin-cechmanek justin-cechmanek self-assigned this Jul 29, 2024
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a note for a future cleanup/refactor -- but LGTM. Great work.

return_fields=return_fields,
)

sorted_query = query.query
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added sort by support to the redisvl query classes -- so you should be able to do this there?

@tylerhutcherson
Copy link
Collaborator

@justin-cechmanek just need to resolve merge conflicts and get tests working, otherwise go ahead an merge away!

@justin-cechmanek justin-cechmanek merged commit a5854be into main Jul 30, 2024
20 checks passed
@justin-cechmanek justin-cechmanek changed the title Feat/raae 194/standard session search index standard session uses hash implementation Jul 30, 2024
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-194/standard-session-search-index branch August 1, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants