-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standard session uses hash implementation #191
standard session uses hash implementation #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a note for a future cleanup/refactor -- but LGTM. Great work.
return_fields=return_fields, | ||
) | ||
|
||
sorted_query = query.query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added sort by support to the redisvl query classes -- so you should be able to do this there?
@justin-cechmanek just need to resolve merge conflicts and get tests working, otherwise go ahead an merge away! |
Replaces the list implementation of Standard Session Manager to use a hash implementation.