-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes setting scope fully optional in session managers #193
Conversation
92619dd
to
0044981
Compare
inside search_cache() what if instead of: |
as_text: bool = False, | ||
raw: bool = False, | ||
tag_filter: Optional[FilterExpression] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my concern here is we blur the conceptual lines between a tag_filter
and a session_tag
. Also we "own" the schema. Users wouldn't know they are supposed to use this field for session filtering. Ideally we make it so it's super clear :)
We could make it clear and ask them to pass the session_tag: Optional[str] = None
here and WE wrap it into a Tag filter since we own the schema and know how to apply it.
This PR removes the requirement that user and session tags be specified on session manager initialization. Session tags can be added when storing messages and filter expressions can be used to retrieve specific chat histories. A default uuid is used when no session is provided.