adds filter fields to cache key name hash #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Create a secure hash of some arbitrary input text.""" | ||
| def hashify(content: str, extras: Optional[Dict[str, Any]] = None) -> str: | ||
| """Create a secure hash of some arbitrary input text and optional dictionary.""" | ||
| if extras: |
There was a problem hiding this comment.
Small preference here to keep hashify dumb and move the filter string processing logic for this to within the generate_id method and pass the final string to hashify.
tylerhutcherson
approved these changes
Sep 27, 2024
rbs333
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to prevent cache entries being overwritten when the exact same prompt string is used, but other cache entry data - like user id, or some other field - is different.