Add Amazon Bedrock Text vectorizer #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
changed the title
tylerhutcherson
requested changes
Nov 26, 2024
Collaborator
tylerhutcherson
left a comment
tylerhutcherson
left a comment
There was a problem hiding this comment.
Great work. Left a few comments!
bsbodden
force-pushed
the
bsb/amazon_bedrock_text_vectorizer
branch
2 times, most recently
from
1da6f20 to
b9bcc9d
Compare
bsbodden
force-pushed
the
bsb/amazon_bedrock_text_vectorizer
branch
from
b9bcc9d to
2e1b074
Compare
Collaborator
tylerhutcherson
left a comment
tylerhutcherson
left a comment
There was a problem hiding this comment.
Docs comment -- overall code looks great. Need tests to pass.
bsbodden
force-pushed
the
bsb/amazon_bedrock_text_vectorizer
branch
4 times, most recently
from
1374da1 to
144a893
Compare
bsbodden
force-pushed
the
bsb/amazon_bedrock_text_vectorizer
branch
from
144a893 to
72c6ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Vectorizer for Amazon Bedrock, along with tests and doc updates.