Skip to content

Support Python 3.13 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Conversation

tylerhutcherson
Copy link
Collaborator

The initial inclusion of Python 3.13 caused issues with our dependencies. This PR addresses this and expands the ecosystem for RedisVL. It also handles some far-too-wide dependency ranges for our requirements and minimizes package resolution time.

@tylerhutcherson tylerhutcherson added enhancement New feature or request maintenance labels Feb 7, 2025
@tylerhutcherson tylerhutcherson force-pushed the feat/RAAE-597-support-python-3_13 branch 2 times, most recently from deb4287 to 76657fb Compare February 7, 2025 20:57
@tylerhutcherson tylerhutcherson changed the title WIP -- Support Python 3.13 Support Python 3.13 Feb 7, 2025
@tylerhutcherson tylerhutcherson marked this pull request as ready for review February 7, 2025 21:08
abrookins
abrookins previously approved these changes Feb 8, 2025
Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 LGTM!

rbs333
rbs333 previously approved these changes Feb 10, 2025
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can successfully poetry install this branch after using pyenv to switch to python 3.13.1 ✅

Test fail when I attempt to run the unit_tests however
image

Seems to be a problem with

worker_id = request.config.workerinput.get("workerid", "master") in conftest not sure if there's an update needed there or something

It also seems like there's a merge thing to resolve

@tylerhutcherson
Copy link
Collaborator Author

I can successfully poetry install this branch after using pyenv to switch to python 3.13.1 ✅

Test fail when I attempt to run the unit_tests however image

Seems to be a problem with

worker_id = request.config.workerinput.get("workerid", "master") in conftest not sure if there's an update needed there or something

It also seems like there's a merge thing to resolve

Yeah this is for the pytest-xdist thing. I would pull main first and kill your poetry env and install from the lock again with poetry install --all-extras

@justin-cechmanek
Copy link
Collaborator

I can successfully poetry install this branch after using pyenv to switch to python 3.13.1 ✅
Test fail when I attempt to run the unit_tests however image
Seems to be a problem with
worker_id = request.config.workerinput.get("workerid", "master") in conftest not sure if there's an update needed there or something
It also seems like there's a merge thing to resolve

Yeah this is for the pytest-xdist thing. I would pull main first and kill your poetry env and install from the lock again with poetry install --all-extras

When I try this HuggingFace was throwing an error about missing torchvision as a dependency. pip install torchvision resolved it

@tylerhutcherson
Copy link
Collaborator Author

I can successfully poetry install this branch after using pyenv to switch to python 3.13.1 ✅
Test fail when I attempt to run the unit_tests however image
Seems to be a problem with
worker_id = request.config.workerinput.get("workerid", "master") in conftest not sure if there's an update needed there or something
It also seems like there's a merge thing to resolve

Yeah this is for the pytest-xdist thing. I would pull main first and kill your poetry env and install from the lock again with poetry install --all-extras

When I try this HuggingFace was throwing an error about missing torchvision as a dependency. pip install torchvision resolved it

When was the error thrown? During install command or during tests?

@tylerhutcherson tylerhutcherson dismissed stale reviews from rbs333 and abrookins via 92a530b February 11, 2025 22:00
@tylerhutcherson tylerhutcherson force-pushed the feat/RAAE-597-support-python-3_13 branch from 92a530b to 655376c Compare February 11, 2025 22:01
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed local:

  • poetry install from lock
  • make test
  • make lint
  • poetry add

@tylerhutcherson tylerhutcherson merged commit ba8142a into main Feb 12, 2025
36 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-597-support-python-3_13 branch February 12, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants