Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing support for Redis 8 (currently
redis:8.0-M03
from Docker) to our GitHub Actions pipeline. Overall, our entire test suite passed against Redis 8 with one notable exception:Breaking Change in Redis 8, Dialect 2 Only
When a search query references a field that is not present in the index schema, Redis 8 now raises:
Previously (and in other dialects), Redis would allow such queries but return empty results. This new behavior is arguably more correct, but it breaks a test that expects an empty result when searching on a non-indexed field.
Context and Discussion
A single test failed where our code intentionally queries a field not in the index, expecting empty results. With Redis 8, Dialect 2, this now raises an error.
The team discussed whether to:
Decision