fix url pass #289
Merged
fix url pass #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrookins
approved these changes
Feb 21, 2025
| @@ -84,6 +84,17 @@ def test_search_index_from_existing(client, index): | |||
| assert index2.schema == index.schema | |||
|
|
|||
|
|
|||
| def test_search_index_from_existing_url(redis_url, index): | |||
rbs333
commented
Feb 21, 2025
| @@ -358,7 +358,7 @@ def _redis_client(self) -> Optional[redis.Redis]: | |||
| with self._lock: | |||
| if self.__redis_client is None: | |||
| self.__redis_client = RedisConnectionFactory.get_redis_connection( | |||
| url=self._redis_url, | |||
| redis_url=self._redis_url, | |||
There was a problem hiding this comment.
personally I think we should always use redis_url vs url because it's more specific and that's what we tend to say when we do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in from_existing where it was not passing the redis_url correctly because the var is named
url