Add batch_search to sync Index #305
Merged
+494
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
approved these changes
Mar 28, 2025
| query, query_params=query_params | ||
| ) | ||
| batch_built_queries.append(q) | ||
| pipe.execute_command( |
There was a problem hiding this comment.
oh what, for real? I thought we just do pipe.ft(<index-name>).search(...) I swear I have code somewhere that does this
There was a problem hiding this comment.
Uhhhh maybe I did it wrong 😂
There was a problem hiding this comment.
Well look at that, pipe.ft().search() works just fine. This is a much better outcome.
There was a problem hiding this comment.
I spoke too soon. search appears to be broken for pipelines. Oh well!
async_index = <redisvl.index.index.AsyncSearchIndex object at 0x10ba26c50>
@pytest.mark.asyncio
async def test_batch_search_with_multiple_batches(async_index):
await async_index.create(overwrite=True, drop=True)
data = [{"id": "1", "test": "foo"}, {"id": "2", "test": "bar"}]
await async_index.load(data, id_field="id")
> results = await async_index.batch_search(
[FilterQuery("@test:{foo}"), FilterQuery("@test:{bar}")],
batch_size=2,
redisvl/index/index.py:1311: in batch_search
await pipe.ft(self.schema.index.name).search( # type: ignore
env/lib/python3.11/site-packages/redis/commands/search/commands.py:945: in search
return self._parse_results(
env/lib/python3.11/site-packages/redis/commands/search/commands.py:72: in _parse_results
return self._RESP2_MODULE_CALLBACKS[cmd](res, **kwargs)
env/lib/python3.11/site-packages/redis/commands/search/commands.py:79: in _parse_search
return Result(
env/lib/python3.11/site-packages/redis/commands/search/result.py:29: in __init__
self.total = res[0]
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <redis.asyncio.client.Pipeline(<redis.asyncio.connection.ConnectionPool(<redis.asyncio.connection.Connection(host=0.0.0.0,port=52824,db=0)>)>)>
name = 0
def __getitem__(self, name: KeyT):
> raise TypeError("Async Redis client does not support class retrieval")
E TypeError: Async Redis client does not support class retrieval
env/lib/python3.11/site-packages/redis/commands/core.py:2551: TypeError
redisvl/index/index.py
Outdated
|
|
||
| for i, query_results in enumerate(results): | ||
| _built_query = batch_built_queries[i] | ||
| parsed_raw = search._parse_search( # type: ignore |
There was a problem hiding this comment.
Smart to tap into the search parsing capabilities baked into redis py :)
justin-cechmanek
pushed a commit
that referenced
this pull request
Apr 2, 2025
Add `batch_search` and `batch_query` methods to `SearchIndex` and `AsyncSearchIndex`. These methods run search commands in a pipeline and return correctly-parsed and post-processed results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
batch_searchmethod toSearchIndexandAsyncSearchIndex. These methods run search commands in a pipeline and return correctly-parsed and post-processed results.TODO:
batch_query