Skip to content

Add embeddings cache #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2025
Merged

Add embeddings cache #318

merged 7 commits into from
Apr 16, 2025

Conversation

tylerhutcherson
Copy link
Collaborator

@tylerhutcherson tylerhutcherson commented Apr 11, 2025

Initial design and refactor here.

  • Includes some clean up for the internals of the OG SemanticCache.
  • Refactors the core of the cache classes to use BaseCache for both EmbeddingsCache and SemanticCache.
  • Updates documentation, working tests, and user guides.

NOTE: Will hold off on integrating with our vectorizers for a separate PR. This one is already long.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Apr 11, 2025
@tylerhutcherson tylerhutcherson changed the base branch from main to 0.6.0 April 11, 2025 02:47
@tylerhutcherson tylerhutcherson marked this pull request as ready for review April 11, 2025 20:48
Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have the one question, but it's not blocking.

Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! 👍

@tylerhutcherson tylerhutcherson merged commit 2e8b167 into 0.6.0 Apr 16, 2025
31 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-229-embeddings-cache branch April 16, 2025 13:45
abrookins pushed a commit that referenced this pull request May 1, 2025
Initial design and refactor here. 
- Includes some clean up for the internals of the OG `SemanticCache`.
- Refactors the core of the cache classes to use `BaseCache` for both
`EmbeddingsCache` and `SemanticCache`.
- Updates documentation, working tests, and user guides.

NOTE: Will hold off on integrating with our vectorizers for a separate
PR. This one is already long.
abrookins pushed a commit that referenced this pull request May 1, 2025
Initial design and refactor here. 
- Includes some clean up for the internals of the OG `SemanticCache`.
- Refactors the core of the cache classes to use `BaseCache` for both
`EmbeddingsCache` and `SemanticCache`.
- Updates documentation, working tests, and user guides.

NOTE: Will hold off on integrating with our vectorizers for a separate
PR. This one is already long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants