-
Notifications
You must be signed in to change notification settings - Fork 46
Add embeddings cache #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add embeddings cache #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-cechmanek
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have the one question, but it's not blocking.
abrookins
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me! 👍
abrookins
pushed a commit
that referenced
this pull request
May 1, 2025
Initial design and refactor here. - Includes some clean up for the internals of the OG `SemanticCache`. - Refactors the core of the cache classes to use `BaseCache` for both `EmbeddingsCache` and `SemanticCache`. - Updates documentation, working tests, and user guides. NOTE: Will hold off on integrating with our vectorizers for a separate PR. This one is already long.
abrookins
pushed a commit
that referenced
this pull request
May 1, 2025
Initial design and refactor here. - Includes some clean up for the internals of the OG `SemanticCache`. - Refactors the core of the cache classes to use `BaseCache` for both `EmbeddingsCache` and `SemanticCache`. - Updates documentation, working tests, and user guides. NOTE: Will hold off on integrating with our vectorizers for a separate PR. This one is already long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial design and refactor here.
SemanticCache
.BaseCache
for bothEmbeddingsCache
andSemanticCache
.NOTE: Will hold off on integrating with our vectorizers for a separate PR. This one is already long.