Rebuild function engines for function flush command #13383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f733883.
… lazyfree thread Co-authored-by: meir <meir@redis.com>
MeirShpilraien
previously approved these changes
Jul 8, 2024
… in 32bit is 73728 bytes
sundb
added
the
release-notes
oranagra
previously approved these changes
Jul 9, 2024
sundb
changed the title
oranagra
approved these changes
Jul 10, 2024
sundb
added a commit
to sundb/redis
that referenced
this pull request
Jul 10, 2024
)" This reverts commit ffff7fe.
sundb
added a commit
to sundb/redis
that referenced
this pull request
Aug 29, 2024
### Issue The current implementation of `FUNCTION FLUSH` command uses `lua_unref()` to unreference script closures in Lua vm. However, invoking `lua_unref()` during lazy free (`ASYNC` argument) is risky since it is not thread-safe. Another issue is that using `lua_unref()` to unreference references does not trigger GC, This can result in the Lua VM leaves a significant amount of garbage, which may never be cleaned up if not properly GC. ### Solution The proposed solution is to completely rebuild the engines, resulting in a brand new Lua VM. --------- Co-authored-by: meir <meir@redis.com>
sundb
added a commit
to sundb/redis
that referenced
this pull request
Aug 29, 2024
…dis#13476) This is a missing of the PR redis#13383. We will call `functionsLibCtxClear()` in bio, so we shouldn't touch `curr_functions_lib_ctx` in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current implementation of
FUNCTION FLUSHcommand useslua_unref()to unreference script closures in Lua vm. However, invokinglua_unref()during lazy free (ASYNCargument) is risky since it is not thread-safe.Another issue is that using
lua_unref()to unreference references does not trigger GC, This can result in the Lua VM leaves a significant amount of garbage, which may never be cleaned up if not properly GC.Solution
The proposed solution is to completely rebuild the engines, resulting in a brand new Lua VM.