Fixed - Inconsistent MaxInactiveInterval Setting in Sessions in multi-node #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-node Signed-off-by: seakider <seakider@gmail.com>
mrniko
requested changes
Mar 10, 2025
redisson-tomcat/redisson-tomcat-10/src/main/java/org/redisson/tomcat/RedissonSession.java
Outdated
Show resolved
Hide resolved
...sson-tomcat/redisson-tomcat-10/src/main/java/org/redisson/tomcat/RedissonSessionManager.java
Show resolved
Hide resolved
…-node Signed-off-by: seakider <seakider@gmail.com>
mrniko
reviewed
Mar 11, 2025
| @@ -263,7 +263,7 @@ private void fastPut(String name, Object value) { | |||
| return; | |||
| } | |||
| m.fastPut(name, value); | |||
| if (readMode == ReadMode.MEMORY && this.broadcastSessionUpdates) { | |||
| if (readMode == ReadMode.REDIS || this.broadcastSessionUpdates) { | |||
There was a problem hiding this comment.
why do we need to change readMode here?
There was a problem hiding this comment.
There are two instances of the application in ReadMode.REDIS mode. Instance a calls setMaxInactiveInterval, and instance b calls getMaxInactiveInterval to get a value that is not the value set by instance a.
There was a problem hiding this comment.
condition should remain unchanged and getMaxInactiveInterval() should be overridden like getIdleTimeInternal()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues/6232