Skip to content

Commit

Permalink
Fix typescript-deno-plugin build
Browse files Browse the repository at this point in the history
  • Loading branch information
redking00 committed Dec 18, 2024
1 parent 6d453f8 commit 9a13f63
Show file tree
Hide file tree
Showing 5 changed files with 86 additions and 16 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Just install the extension, look at the releases section. No need for Jupyter or

> ⚠️ **Important:**
> Remember deno.enable:true in the workspace that contains the notebooks. The best way is to use the command _Deno: Initialize
Workspace Configuration_ (adds some more configuration besides deno.enable).
Workspace Configuration_.


Rename any .ts file to .nb.ts to get started. You can also start with an empty file:
Expand Down
2 changes: 0 additions & 2 deletions client/src/commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,6 @@ export function enable(
return async () => {
const config = vscode.workspace.getConfiguration(EXTENSION_NS);
await config.update("enable", true);
await vscode.workspace.getConfiguration('typescript.validate').update('enable', false);
vscode.window.showInformationMessage("Deno workspace initialized.");
const tsserverConfig = vscode.workspace.getConfiguration(
"typescript.tsserver",
Expand Down Expand Up @@ -703,7 +702,6 @@ export function disable(
return async () => {
const config = vscode.workspace.getConfiguration(EXTENSION_NS);
await config.update("enable", undefined);
await vscode.workspace.getConfiguration('typescript.validate').update('enable', undefined);
};
}

Expand Down
3 changes: 1 addition & 2 deletions devcontainer-root/.vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{
"deno.enable": true,
"typescript.validate.enable": false
"deno.enable": true
}
87 changes: 80 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Visual Studio Code plugin for Deno lsp support on notebooks (+ NBTS serializer + DenoNBTS kernel)",
"author": "redking00 & Deno Land Inc.",
"license": "MIT",
"version": "1.0.18",
"version": "1.0.19",
"icon": "deno.png",
"galleryBanner": {
"color": "#3B3738",
Expand Down Expand Up @@ -871,7 +871,7 @@
]
},
"scripts": {
"vscode:prepublish": "npm i && npm run esbuild-plugin && npm i && npm run esbuild-base",
"vscode:prepublish": "npm i && npm run esbuild-plugin && npm i && npm run esbuild-base && copy-folder typescript-deno-plugin node_modules/typescript-deno-plugin",
"esbuild-base": "esbuild ./client/src/extension.ts --bundle --outfile=client/dist/main.js --external:vscode --external:zeromq --format=cjs --platform=node",
"esbuild-plugin": "esbuild ./typescript-deno-plugin/src/index.ts --bundle --outfile=typescript-deno-plugin/dist/index.js --external:vscode --format=cjs --platform=node",
"esbuild": "npm run esbuild-plugin -- --sourcemap && npm run esbuild-base -- --sourcemap",
Expand All @@ -881,11 +881,11 @@
"postinstall": "cd typescript-deno-plugin && npm i && cd ../client && npm i && cd .."
},
"dependencies": {
"zeromq": "6.0.8",
"typescript-deno-plugin": "./typescript-deno-plugin"
"zeromq": "6.0.8"
},
"devDependencies": {
"@types/node": "^14.14.25",
"copy-folder-util": "^1.1.4",
"esbuild": "^0.14.23",
"typescript": "^5.0.2"
}
Expand Down

0 comments on commit 9a13f63

Please sign in to comment.