Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Interface reorganization #150

Merged
merged 11 commits into from
Nov 17, 2024
Merged

Web Interface reorganization #150

merged 11 commits into from
Nov 17, 2024

Conversation

rednblkx
Copy link
Owner

@rednblkx rednblkx commented Nov 9, 2024

Restructured the various sections into tabbed interfaces

  • Split settings into HomeKit, PN532, and HomeSpan tabs
  • Added WebUI authentication settings under dedicated tab
  • Changed "Home Key controlled state" to "Actionable by HomeKey"
  • Updated HomeKit trigger description to clarify optional HomeKey authentication
  • Improved input field widths for better visual consistency
  • Split HomeKey Triggers into Neopixel and Simple GPIO tabs

Summary by CodeRabbit

  • New Features

    • Introduced new forms for configuring miscellaneous device settings and MQTT settings, enhancing user interaction and configuration capabilities.
    • Added responsive design elements and new CSS classes for improved layout and styling across various screen sizes.
    • Implemented tabbed navigation for better organization of settings within forms.
  • Bug Fixes

    • Improved error handling for GPIO pin assignments to ensure valid configurations.
  • Documentation

    • Updated user interface elements for clarity and ease of use, including simplified labels and better layout organization.

Copy link

coderabbitai bot commented Nov 9, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across various files, primarily focusing on enhancing the UI layout and functionality. Key changes include the addition of new CSS classes for styling and responsive design, the introduction of new HTML forms for MQTT and miscellaneous settings, and updates to JavaScript functions for improved tab navigation and form handling. Additionally, the MQTT configuration structure has been adjusted in the C++ code, including changes to topic management and web server path handling.

Changes

File Change Summary
data/assets/misc.css Added new CSS classes: .fill-container, .buttons-group, .destructive-btn, .selected-btn, and media queries for responsive design. Adjusted existing media queries and hover effects for buttons.
data/index.html Added a new function switchTab(el) for tab switching; modified addComponent(name, button) to remove max-width from el and updated fetch call to use template literals.
data/misc.html Deleted file containing a form for device configuration settings, including HomeKit and NFC settings.
data/mqtt.html Deleted file containing a form for configuring MQTT settings with various input fields and JavaScript for asynchronous submission.
data/routes/actions.html Modified HTML form structure, added cards-container for layout flexibility, simplified labels, and restructured "HomeKit Triggers" section with updated tabbed navigation.
data/routes/misc.html Introduced a new form for configuring miscellaneous settings with tabs, input fields, and asynchronous JavaScript for form submission.
data/routes/mqtt.html Introduced a new form for MQTT configuration with sections for Broker Connection and MQTT Topics, including validation and asynchronous submission handling.
src/main.cpp Updated MQTT configuration structure to change topic handling, adjusted paths for static web handlers, and added validation checks for GPIO pin assignments. Minor adjustments to logging and response messages were also made.

Possibly related PRs

  • Momentary state improvement #146: The changes in this PR involve modifications to the HTML form in data/actions.html, which may interact with the new CSS classes introduced in the main PR, particularly regarding layout and styling for the HomeKit triggers.

🐰 In the code we hop and play,
New styles and forms brighten the day.
With tabs that switch and layouts that flex,
Our UI shines, oh what a complex!
From MQTT to settings, all in a row,
Hooray for the changes, let our features grow! 🌼

Warning

Rate limit exceeded

@rednblkx has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 691ddd3 and cb34d7f.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rednblkx rednblkx changed the title restructured the miscellaneous section under tabs UI/UX improvements and settings reorganization Nov 9, 2024
@rednblkx rednblkx changed the title UI/UX improvements and settings reorganization Missecellaenous section reorganization Nov 9, 2024
@rednblkx rednblkx changed the title Missecellaenous section reorganization Miscellaneous section reorganization Nov 9, 2024
@rednblkx rednblkx marked this pull request as ready for review November 9, 2024 20:43
@rednblkx rednblkx changed the title Miscellaneous section reorganization Web Interface reorganization Nov 9, 2024
@rednblkx rednblkx changed the base branch from nfc-custom-pins to main November 15, 2024 14:08
@rednblkx rednblkx changed the base branch from main to nfc-custom-pins November 15, 2024 14:12
Copy link
Owner Author

rednblkx commented Nov 17, 2024

Merge activity

  • Nov 17, 12:30 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 17, 12:37 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 17, 12:38 PM EST: A user merged this pull request with Graphite.

@rednblkx rednblkx changed the base branch from nfc-custom-pins to graphite-base/150 November 17, 2024 17:33
@rednblkx rednblkx changed the base branch from graphite-base/150 to main November 17, 2024 17:35
@rednblkx rednblkx merged commit aec4631 into main Nov 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant