Make env: return ENOENT on non-existent; support unlink() #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, we should see how it ends up working |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 22, 2017
Redox: Use create() instead of open() when setting env variable See redox-os/kernel#25.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 22, 2017
Redox: Use create() instead of open() when setting env variable See redox-os/kernel#25.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 23, 2017
Redox: Use create() instead of open() when setting env variable See redox-os/kernel#25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also requires a small modification to libstd; I guess I'll submit a PR to redox-os/rust, and if it looks okay a PR can be sent upstream as well. Everything has to be rebuilt for this change, if it sets environmental variables. That seems unavoidable though.
Hopefully this is okay, but I don't know why that if condition was commented out, so perhaps it causes issues I'm not aware of.