Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticsearch): add retry_on_conflict option on output #3147

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

defgenx
Copy link
Contributor

@defgenx defgenx commented Jan 27, 2025

Description

This introduces the RetryOnConflict option to the Elasticsearch output configuration. This option allows users to specify the number of times an update or upsert should be retried in the case of a version conflict.
This feature is useful for scenarios where multiple clients might be updating the same document concurrently, and version conflicts are expected.

Change(s)

  • Added RetryOnConflict field to the Elasticsearch output configuration.

Testing

  • I didn't see any unit tests for this connector so I'm not sure how we could test it as it is.

Issue(s)

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2025

CLA assistant check
All committers have signed the CLA.

@nept
Copy link

nept commented Feb 4, 2025

Great addition for the elasticsearch configuration! 👌

Copy link
Collaborator

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mihaitodor mihaitodor merged commit cb682fd into redpanda-data:main Feb 4, 2025
4 checks passed
@defgenx defgenx deleted the feat-add-retry-on-conflict branch February 4, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants