Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message search UX #70

Closed
rikimaru0345 opened this issue Jul 10, 2020 · 2 comments · Fixed by #80
Closed

Improve message search UX #70

rikimaru0345 opened this issue Jul 10, 2020 · 2 comments · Fixed by #80
Assignees
Labels
backend feature New feature or request frontend

Comments

@rikimaru0345
Copy link
Contributor

Some things from #48 didn't make it into #54

Helper functions (Important!)

What if the user wants to search for one specific property in a deeply nested object?
There should be a function that takes the name of a property (or partial path!), like:
findProp("player.score") to return the value of the first matching property.
Also: findPropAll("...") to return an array of all matches.

UX Improvements

  1. Filter Settings
    The filter "tags" (or "pills") are currently not somewhat awkward to use since they can be clicked once to toggle them on/off, and double-clicked to open their properties.
    The double-click functionality should probably be replaced a gear icon on the left side.
    That way a filter entry would have 3 clickable regions: Settings - On/Off Toggle - Delete

  2. JS Examples
    The examples section is currently just a placeholder...

Expression Editor

In order to be able to provide an expression editor (with dropdowns for existing properties like in kibana), the frontend needs a list of all the properties.

This will probably take a while because it pretty much requires the "schema detection" feature, which in turn most likely requires a database...

Bytes (Later)

Eventually we probably want to be able to work with the raw message as well (so provide something like a Buffer(?) from nodejs so the user can access the bytes)

@rikimaru0345 rikimaru0345 added feature New feature or request frontend backend labels Jul 10, 2020
@rikimaru0345 rikimaru0345 added this to the 1.1 release milestone Jul 22, 2020
@rikimaru0345
Copy link
Contributor Author

  • for 1.1 we won't be able to add the expression editor since it requires some significant backend work.
  • "byte access" is not important enough right now either.

however for 1.1 the remaining points are pretty important:

  1. helper functions (findProp, findPropAll, and more, if we can think of any more interesting/convincing use-cases)
  2. "filter settings ux": double-click on a filter is the main issue, that needs to go! Turning the a filter button from a 2-part [ FilterName | CloseX ] thing into a 3-part thing [ Settings Gear Icon | FilterName | CloseX ] is probably the best solution here.
  3. The "info" bar at the bottom of the JS dialog is still a placeholder. We definitely need more basic info, as well as some good examples there that cover common use cases...

@rikimaru0345
Copy link
Contributor Author

It is entirely possible to just add the helper functions to the frontend (adding/injecting) them into the code that "compiles" the filters to "JS source code",
its not a clean solution however. The helper functions never change, so they should be part of the "js environment" in the backend and stored there. (No point in sending them over the wire every time a search is done that uses a filter...)

For debugging/testing they can of course be added to the frontend. (I wouldn't even mind to release 1.1 like that! As long as we eventually move them to the backend...)

rjmasikome pushed a commit to rjmasikome/kowl that referenced this issue Jul 26, 2020
@weeco weeco linked a pull request Jul 26, 2020 that will close this issue
3 tasks
rikimaru0345 added a commit that referenced this issue Jul 30, 2020
[In progress] #70 Improving the UX of Filter
rikimaru0345 added a commit that referenced this issue Aug 2, 2020
commit 4968a61
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Sun Aug 2 17:11:39 2020 +0200

    adapt to new admin endpoint changes; fixes #53

commit 2db7a3a
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Sat Aug 1 15:11:10 2020 +0200

    wip: adapt to changed response from api/admin/

commit bc2ec9d
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Sat Aug 1 15:08:51 2020 +0200

    npm audit fix

commit f09e6b3
Merge: 7b79bd7 6c7bc9c
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Thu Jul 30 19:24:20 2020 +0200

    Merge branch 'master' of https://github.com/cloudhut/kowl

commit 6c7bc9c
Merge: 4b79414 b045f04
Author: Moritz Staudinger <rikimaru0345@users.noreply.github.com>
Date:   Thu Jul 30 19:20:54 2020 +0200

    Merge pull request #77 from rjmasikome/feature/#30

commit b045f04
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Thu Jul 30 19:19:39 2020 +0200

    update relative timestamps, fixes #86

commit f0637c3
Merge: fb9743a 4b79414
Author: Moritz Staudinger <rikimaru0345@users.noreply.github.com>
Date:   Thu Jul 30 19:05:19 2020 +0200

    Merge branch 'master' into feature/#30

commit 4b79414
Merge: 278312f 9a6e1e0
Author: Moritz Staudinger <rikimaru0345@users.noreply.github.com>
Date:   Thu Jul 30 18:32:06 2020 +0200

    Merge pull request #80 from rjmasikome/feature/#70

    [In progress] #70 Improving the UX of Filter

commit 7b79bd7
Merge: 7b27819 278312f
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Thu Jul 30 17:09:33 2020 +0200

    Merge branch 'master' of https://github.com/cloudhut/kowl

commit 9a6e1e0
Author: Rian Josua Masikome <rian.masikome@rewe-digital.com>
Date:   Wed Jul 29 00:45:06 2020 +0200

    add findProp helper to filter function

commit 7b27819
Author: rikimaru0345 <rikimaru0345@users.noreply.github.com>
Date:   Tue Jul 28 19:13:15 2020 +0200

    don't show second info bar in message search StatusIndicator when "filter" option is toggled off

commit 87f3dc4
Author: Rian Josua Masikome <rian.masikome@rewe-digital.com>
Date:   Sun Jul 26 23:29:34 2020 +0200

    add some examples

commit c93654f
Author: Rian Josua Masikome <rian.masikome@rewe-digital.com>
Date:   Sun Jul 26 12:34:58 2020 +0200

    fix order

commit da9f4cc
Author: Rian Josua Masikome <rian.masikome@rewe-digital.com>
Date:   Sun Jul 26 12:24:13 2020 +0200

    adding cog icon on the tag #70

commit fb9743a
Author: Rian Josua Masikome <rian.masikome@rewe-digital.com>
Date:   Sat Jul 25 11:48:12 2020 +0200

    add more copy options #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature New feature or request frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants