Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of long names in the tables & breadcrumbs #1124

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

jvorcak
Copy link
Collaborator

@jvorcak jvorcak commented Feb 19, 2024

  1. I think having it in the breadcrumb is a good thing when it comes to consistency. We currently have the detail items there for all the pages I know of.

  2. I think it's however OK to cut it when needed (we have no other choice). I've worked on a prototype that takes all the possible space and adds ... once needed. (Please note that the whitespace at the end is needed for the refreshing text, if we could get rid of that it could go til the end).

Screenshot 2024-02-19 at 12 09 18 PM
Screenshot 2024-02-19 at 12 14 57 PM

However in this scenario we would need to add copy to clipboard icon so that users can copy it if it's too long. Sth like github does
Screenshot 2024-02-19 at 12 17 39 PM

In the tables I prototyped the solution that would take n number of lines before it shows ...
Screenshot 2024-02-19 at 12 15 37 PM

WDYT?

@ivpanda
Copy link

ivpanda commented Feb 20, 2024

I like the ... solution for the breadcrumbs and in the tables. In the tables, I'd like to keep everything to one line rather than multiples.

I would also agree that we need to add a copy ID button somewhere. To this end, I'm struggling a little with the difference here between console and the regular UI, where we have a title for topics and we could do something like the below:

image

Instead, in this case, we'd have to put the copy button in the breadcrumb, which doesn't feel right to me. How much room do we have here to make/propose changes right now?

@jvorcak
Copy link
Collaborator Author

jvorcak commented Feb 20, 2024

I like the ... solution for the breadcrumbs and in the tables. In the tables, I'd like to keep everything to one line rather than multiples.

I would also agree that we need to add a copy ID button somewhere. To this end, I'm struggling a little with the difference here between console and the regular UI, where we have a title for topics and we could do something like the below:

image Instead, in this case, we'd have to put the copy button in the breadcrumb, which doesn't feel right to me. How much room do we have here to make/propose changes right now?

I think we have no limitations right now. What would help me is to showcase how it should be in the console (and cloud) for the long names and I can provide an implementation.

When it comes to the tables, so we will stick with one line only and ... right?

@ivpanda
Copy link

ivpanda commented Feb 20, 2024

When it comes to the tables, so we will stick with one line only and ... right?

Yes. The user can then click the table item to view the details page and copy the full name.

What would help me is to showcase how it should be in the console (and cloud) for the long names and I can provide an implementation.

My preference would be to have the two be consistent, and console echo Cloud's header, with breadcrumbs and titles, rather than only breadcrumb as is in console:

image

I understand that the breadcrumb may be smaller in Console, but making them similar in style and bringing the title of the page in below them would help a great deal.

@jvorcak
Copy link
Collaborator Author

jvorcak commented Feb 21, 2024

@ivpanda I think that is related to https://github.com/redpanda-data/console-enterprise/issues/190

Maybe it would be the best if we could have a call today and sync about all of the details.

@ivpanda
Copy link

ivpanda commented Feb 21, 2024

After a call, we've decided to add a copy button to the other buttons in the breadcrumb. In Cloud, we'll add the copy button to the same set of buttons that appear in the title:

image

Then, when this issue is implemented, we'll keep the button in the title.

@jvorcak jvorcak marked this pull request as ready for review February 28, 2024 09:31
@jvorcak
Copy link
Collaborator Author

jvorcak commented Feb 28, 2024

Screenshot 2024-02-28 at 10 31 15


Before:
Screenshot 2024-02-23 at 2 36 39 PM

After:
Screenshot 2024-02-23 at 2 41 47 PM


Before:

Screenshot 2024-02-23 at 9 36 28 AM

After:

Screenshot 2024-02-23 at 9 36 19 AM


Before:
Screenshot 2024-02-23 at 9 03 47 AM

After (I've added the copy button)

Screenshot 2024-02-23 at 9 29 14 AM
Screenshot 2024-02-23 at 9 28 40 AM


After:
Screenshot 2024-02-28 at 10 45 12

@weeco weeco requested a review from rikimaru0345 February 28, 2024 11:00
@jvorcak
Copy link
Collaborator Author

jvorcak commented Feb 29, 2024

Screenshot 2024-02-29 at 10 26 08
Screenshot 2024-02-29 at 10 26 02
Screenshot 2024-02-29 at 10 24 54

@jvorcak jvorcak merged commit 35248b8 into master Feb 29, 2024
6 checks passed
@jvorcak jvorcak deleted the fix/better-handling-of-long-names branch February 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants