License nagging #1455
License nagging #1455
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
| enterpriseFeatures, err := s.adminapiCl.GetEnterpriseFeatures(ctx) | ||
| if err == nil { | ||
| isViolation = enterpriseFeatures.Violation | ||
| } |
There was a problem hiding this comment.
if GetEnterpriseFeatures fails we default to "no violation"... is that intentional?
Couldn't just someone turn off / ensure this endpoint fails and always have a valid license?
There was a problem hiding this comment.
Yes this is intentional, since we will also be dealing with Redpanda clusters that do not yet implement this new endpoint. It is not a problem, because this is just some soft nagging / reminding the users that they are violating the license. If we are not certain they are violating the license we better be quiet was the idea here
frontend/src/state/backendApi.ts
Outdated
| this.enterpriseFeaturesUsed = enterpriseFeaturesResponse.features; | ||
|
|
||
| // Handle the second response | ||
| this.licenses = licensesResponse.licenses; | ||
| this.licenseViolation = licensesResponse.violation; |
There was a problem hiding this comment.
what if enterpriseFeaturesResponse is of type Errorr? which can happen because ofthe catch and "return err" in line 1567
There was a problem hiding this comment.
@rikimaru0345 can you please check now?
Failed state
|
|
LGTM! Just two small comments on the errors, if we could show them using our error components, like this: On the Admin page:
In the Details box:
Thanks! |
I'd try to avoid showing "... or upload a new license" WDYT? |
|
|
|
@jvorcak Also, I am confused why we still see different license status in license details. Uploading an Enterprise license is supposed to also push the license to the Redpanda cluster (what now says 'Core Community'). This part should should say 'Repanda Community Edition' or 'Redpanda Enterprise Edition', and after upload of a license at a minimum both should be 'Enterprise'. The Console one should be 'Console Community Edition', 'Console Enterprise Edition. Also, a header for 'Expiry Date' column would be nice. |
|
@mattschumpert I've addressed the details we talked about in #1464 |
This pull request changes:
ListEnterpriseFeaturesRPC to console pkg (may return CodeUnimplemented if unreachable or unimplemented)violationbool in ListLicenses response (defaults to false if admin api endpoint is unreachable or unimplemented)Has a dependency on: redpanda-data/common-go#24