Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve path encoded subjects in middleware #1526

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

pkwarren
Copy link
Contributor

Update basePathMiddleware to use RawPath (if present) over Path to ensure that URL path encoded subjects are preserved when routing requests.

Update the middleware to also remove the prefix from RawPath for consistency.

Fixes #1525.

Verified

This commit was signed with the committer’s verified signature.
pkwarren Philip K. Warren
Update basePathMiddleware to use `RawPath` (if present) over `Path` to
ensure that URL path encoded subjects are preserved when routing
requests.

Update the middleware to also remove the prefix from `RawPath` for
consistency.

Fixes redpanda-data#1525.
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@weeco weeco self-requested a review November 27, 2024 15:46

Verified

This commit was signed with the committer’s verified signature.
pkwarren Philip K. Warren
@weeco weeco merged commit 50d7797 into redpanda-data:master Dec 3, 2024
2 checks passed
@weeco
Copy link
Contributor

weeco commented Dec 3, 2024

Thanks for raising the issue and taking the time to fix it with this PR @pkwarren !

@pkwarren pkwarren deleted the pkw/issue-1525 branch December 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-default basePath causes issues with URL path escaped subject names
3 participants