frontend: fix base64 decoding of 'utf8WithControlChars' #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojand
force-pushed
the
rel-2.3/base64-fix
branch
2 times, most recently
from
9c76349
to
ffca4db
Compare
bojand
force-pushed
the
rel-2.3/base64-fix
branch
from
ffca4db
to
2dacd0b
Compare
weeco
approved these changes
Aug 31, 2023
rikimaru0345
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually brings in ef7801a to release branch.
Tested by checking out
release-2.3branch and I was able to reproduce the rendering issue with the JavaScript stack trace.With this change the messages rendered fine.