Skip to content

Commit

Permalink
Merge pull request #101 from amuraru/cached-groups
Browse files Browse the repository at this point in the history
Use cached consumer groups when listing offsets via Admin API
weeco authored Aug 2, 2021

Verified

This commit was signed with the committer’s verified signature.
sagikazarmark Márk Sági-Kazár
2 parents f96bc3a + b6b6b4c commit 5a7a20a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion minion/consumer_group_offsets.go
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ func (s *Service) ListAllConsumerGroupOffsetsInternal() map[string]map[string]ma

// ListAllConsumerGroupOffsetsAdminAPI return all consumer group offsets using Kafka's Admin API.
func (s *Service) ListAllConsumerGroupOffsetsAdminAPI(ctx context.Context) (map[string]*kmsg.OffsetFetchResponse, error) {
groupsRes, err := s.listConsumerGroups(ctx)
groupsRes, err := s.listConsumerGroupsCached(ctx)
if err != nil {
return nil, fmt.Errorf("failed to list groupsRes: %w", err)
}

0 comments on commit 5a7a20a

Please sign in to comment.