[helm-chart] Append customLabels to all resources if defined #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeco
reviewed
Aug 2, 2021
There was a problem hiding this comment.
Hey Adi,
two questions:
- What do you think about adding the custom labels into the helpers.tpl -> kminion.labels. I'm unsure if that would make sense but given that we want to have the labels present in all resources I think this would be a good way to ensure this for the future.
- Is the
toYamlactually necessary? The input has to be YAML anyways no?
|
Good call Martin - added custom labels in the kminion.labels template function |
weeco
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append .Values.customLabels to all resources if defined