Allow directory of payload files #115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the payload file is a diretory, load all immediate child files as payloads for the workload.
|
|
travisdowns
reviewed
May 8, 2024
| @@ -120,7 +121,15 @@ public TestResult run() throws Exception { | |||
| } | |||
| } | |||
| else { | |||
| producerWorkAssignment.payloadData.add(payloadReader.load(workload.payloadFile)); | |||
| File payloadFile = new File(workload.payloadFile); | |||
There was a problem hiding this comment.
Really good idea to re-use the existing filename field, I'd only add that if it contains no files maybe just assert out with "directory was empty" or smth.
There was a problem hiding this comment.
Do you think it's worth it to recursively search the directory? I didn't do it at first just because I wanted to try the idea. I'm not sure what the user would expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the payload file is a diretory, load all immediate child files as payloads for the workload.