pvcunbinder: update to Kubernetes 1.29.x #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
approved these changes
Aug 6, 2024
chrisseto
force-pushed
the
chris/p/fix-unbinder
branch
from
1a02fa7 to
2456f92
Compare
Prior to this commit the pvcunbinder was being tested against Kubernetes ~1.20 (Thanks Rafal for catching this). This commit updates to the latest working version of K3s (1.29.6) and updates the pvcunbinder to work on the newer version. This update introduced two changes of note: 1. The `node volume affinity` error message is no longer a reliable way to detect node volume affinity issues. While this error message still exists within the K8s codebase, it doesn't appear to surface anymore. Instead we see messages about preemption being ineffective. Detection has been updated to look for a message indicate that no node are suitable for the given Pod, a much more relaxed constraint. 2. K3s' default volume type for local-path-provisioner has been updated to `local` instead of `hostpath`. All conditionals have been updated to account for either type of local volume.
RafalKorepta
force-pushed
the
chris/p/fix-unbinder
branch
from
2456f92 to
bf4e7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the pvcunbinder was being tested against Kubernetes ~1.20 (Thanks Rafal for catching this).
This commit updates to the latest working version of K3s (1.29.6) and updates the pvcunbinder to work on the newer version.
This update introduced two changes of note:
node volume affinityerror message is no longer a reliable way to detect node volume affinity issues. While this error message still exists within the K8s codebase, it doesn't appear to surface anymore. Instead we see messages about preemption being ineffective. Detection has been updated to look for a message indicate that no node are suitable for the given Pod, a much more relaxed constraint.localinstead ofhostpath. All conditionals have been updated to account for either type of local volume.