-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to merge users.txt file into bootstrap.yaml #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to copy the explanation from PR cover letter to the commit message.
chrisseto
reviewed
Oct 16, 2024
chrisseto
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
andrewstucki
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Oct 18, 2024
…#1567) This adds the `--users-directory` command line flag needed to leverage redpanda-data/redpanda-operator#265
RafalKorepta
pushed a commit
to RafalKorepta/redpanda-operator
that referenced
this pull request
Nov 8, 2024
… (#1567) This adds the `--users-directory` command line flag needed to leverage redpanda-data#265
RafalKorepta
pushed a commit
that referenced
this pull request
Dec 2, 2024
… (#1567) This adds the `--users-directory` command line flag needed to leverage #265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a routine to merge
users.txt
into the bootstrap.yaml read when performing post install/update jobs. This is needed due to the bootstrap user additions added in this commit causing redpanda-data/helm-charts#1566.What is essentially occuring is this:
REDPANDA_BOOTSTRAP_USER
environment variable said user isn't marked automatically as a superuseradmin_api_require_auth
then the only way you can actually run management operations on your installation is to pass in the above user in to the nodes'bootstrap.yaml
so that the user is immediately marked as a superuser and all of the config-watcher scripts that manage other specified users can leverage it to create the rest of the users.bootstrap.yaml
uncovered that setting any sort ofsuperusers
values in the bootstrap.yaml is incompatible with the users created by a pre-existingusers.txt
secret. This is due to thesuperusers
entry found in the bootstrap.yaml not containing them. When an upgrade finishes the jobs reset the configuration to only contain what is found insuperusers
without regard to anything managed by the pre-existing secret/config-watcher.Since we must still set the bootstrap user in the
superusers
section ofbootstrap.yaml
in order foradmin_api_require_auth
to function correctly on installations, this makes the config synchronization code aware of ourusers.txt
.It needs to be coupled with a change in the
helm-charts
code to add in a--users-txt
flag as needed and an additional secrets mount to mount theusers.txt
file into our job containers.