Sync Redpanda clusterSpec to align with upstream helm chart values #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
force-pushed
the
rk/sync-redpanda-values
branch
from
0f4e3ae to
f7fc30d
Compare
chrisseto
approved these changes
Oct 17, 2024
|
Looks like this supersedes #262 ? |
|
Oh right! |
|
I can close the other PR (which I totally forgot to merge, sorry!). Did we actually want to expose |
I'm happy to remove it. @david-yu what are you thought? |
Reference redpanda-data/helm-charts#1559 https://github.com/redpanda-data/helm-charts/blob/56e8cc7a5e8a34ed1a27c8073490e76493ecda86/charts/redpanda/values.go#L679 redpanda-data/helm-charts#1547 https://github.com/redpanda-data/helm-charts/blob/56e8cc7a5e8a34ed1a27c8073490e76493ecda86/charts/redpanda/values.go#L914 https://github.com/redpanda-data/helm-charts/blob/56e8cc7a5e8a34ed1a27c8073490e76493ecda86/charts/redpanda/values.go#L916
RafalKorepta
force-pushed
the
rk/sync-redpanda-values
branch
from
f7fc30d to
f4f4dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
redpanda-data/helm-charts#1559 https://github.com/redpanda-data/helm-charts/blob/56e8cc7a5e8a34ed1a27c8073490e76493ecda86/charts/redpanda/values.go#L679