Skip to content

Commit

Permalink
cluster/self_test: add test_type to cloudcheck cases
Browse files Browse the repository at this point in the history
`test_type` was not being set in early exit cases for `cloudcheck`.
This would result in longer than expected output (with `IOPS`,
`THROUGHPUT`, `LATENCY` in `rpk cluster self-test status`).
  • Loading branch information
WillemKauf committed Jul 30, 2024
1 parent 3bac4dc commit 147d5e9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/v/cluster/self_test/cloudcheck.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ cloudcheck::run(cloudcheck_opts opts) {
vlog(clusterlog.debug, "cloudcheck - gate already closed");
auto result = self_test_result{
.name = _opts.name,
.test_type = "cloud",
.start_time = time_since_epoch(ss::lowres_system_clock::now()),
.end_time = time_since_epoch(ss::lowres_system_clock::now()),
.warning = "cloudcheck - gate already closed"};
Expand All @@ -64,6 +65,7 @@ cloudcheck::run(cloudcheck_opts opts) {
"Cloud storage is not enabled, exiting cloud storage self-test.");
auto result = self_test_result{
.name = _opts.name,
.test_type = "cloud",
.start_time = time_since_epoch(ss::lowres_system_clock::now()),
.end_time = time_since_epoch(ss::lowres_system_clock::now()),
.warning = "Cloud storage is not enabled."};
Expand All @@ -77,6 +79,7 @@ cloudcheck::run(cloudcheck_opts opts) {
"self-test.");
auto result = self_test_result{
.name = _opts.name,
.test_type = "cloud",
.start_time = time_since_epoch(ss::lowres_system_clock::now()),
.end_time = time_since_epoch(ss::lowres_system_clock::now()),
.warning = "cloud_storage_api is not initialized."};
Expand Down

0 comments on commit 147d5e9

Please sign in to comment.