Skip to content

Commit

Permalink
cloud_storage_clients: add BlobNotFound check
Browse files Browse the repository at this point in the history
Previously, we were checking for a `PathNotFound` result in
`abs_client::do_delete_path()`. However, we should also check for
`BlobNotFound`, so that `error_code::key_not_found` errors don't
propagate from the `abs_client` to the `remote` object.

(cherry picked from commit c85024a)
  • Loading branch information
WillemKauf authored and vbotbuildovich committed May 31, 2024
1 parent 2d8125c commit 5345c3a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/v/cloud_storage_clients/abs_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,9 @@ ss::future<> abs_client::do_delete_path(
try {
co_await do_delete_file(name, *iter, timeout);
} catch (const abs_rest_error_response& abs_error) {
if (abs_error.code() == abs_error_code::path_not_found) {
if (
abs_error.code() == abs_error_code::path_not_found
|| abs_error.code() == abs_error_code::blob_not_found) {
vlog(
abs_log.debug,
"Object to be deleted was not found in cloud storage: "
Expand Down

0 comments on commit 5345c3a

Please sign in to comment.