Skip to content

Commit

Permalink
cloud_storage: reword code comment for in_stm with timequery
Browse files Browse the repository at this point in the history
I believe this makes it clearer.
  • Loading branch information
nvartolomei committed May 17, 2024
1 parent 5ae5fcd commit 943aa52
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/v/cloud_storage/async_manifest_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -905,11 +905,10 @@ bool async_manifest_view::in_stm(async_view_search_query_t o) {
vlog(
_ctxlog.debug, "Checking timestamp {} using timequery", ts_query);
if (_stm_manifest.get_spillover_map().empty()) {
// The STM manifest is empty, so the timestamp has to be directed
// to the STM manifest.
// Implicitly, this case also handles the empty manifest case
// because the STM manifest with spillover segments is never
// empty.
// The spillover manifest is empty, so the timestamp query has to
// be directed to the STM manifest. Otherwise, we can safely
// direct the query either to spillover or stm because the
// STM manifest with spillover segments is never empty.
return true;
}
// The last timestamp in the archive is used as a pivot point. See
Expand Down

0 comments on commit 943aa52

Please sign in to comment.