Merge pull request #22738 from bharathv/fix_set_value_assert

[backport][24.1.x] producer/request_state: make set_value() idempotent
redpanda-data · Aug 6, 2024 · a5ccb14 · a5ccb14
2 parents a39076d + a2f2f07
commit a5ccb14
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/v/cluster/producer_state.cc b/src/v/cluster/producer_state.cc
@@ -32,12 +32,10 @@ result_promise_t::future_type request::result() const {
 }
 
 void request::set_value(request_result_t::value_type value) {
-    vassert(
-      _state <= request_state::in_progress && !_result.available(),
-      "unexpected request state during result set: {}",
-      *this);
-    _result.set_value(value);
-    _state = request_state::completed;
+    if (_state != request_state::completed) {
+        _result.set_value(value);
+        _state = request_state::completed;
+    }
 }
 
 void request::set_error(request_result_t::error_type error) {