Skip to content

Commit

Permalink
cloud_storage: throw if can not create manifest cursor
Browse files Browse the repository at this point in the history
It is not reasonable to continue work after this point. The absence of a
cursor cursor is interpreted as EOF in other parts of the system. Not
throwing makes it impossible to differentiate between "no more data
available" vs. "an error occurred".

This is required for an upcoming commit that fixes a timequery bug where
cloud storage returns "no offset found" instead of propagating an
internal error.
  • Loading branch information
nvartolomei committed May 17, 2024
1 parent aab5fe7 commit b53deac
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/v/cloud_storage/remote_partition.cc
Original file line number Diff line number Diff line change
Expand Up @@ -619,12 +619,10 @@ class partition_record_batch_reader_impl final
co_return;
}

vlog(
_ctxlog.error,
throw std::runtime_error(fmt::format(
"Failed to query spillover manifests: {}, query: {}",
cur.error(),
query);
co_return;
query));
}
_view_cursor = std::move(cur.value());
co_await _view_cursor->with_manifest(
Expand Down

0 comments on commit b53deac

Please sign in to comment.