Skip to content

Commit

Permalink
rptest: change fips decorator in test_s3_oracle_self_config
Browse files Browse the repository at this point in the history
This test will ALWAYS fail in fips mode, due to required path-style
outcome for OCI self configuration.

Change the decorator from `@ok_to_fail_fips` to `@skip_fips_mode`
to avoid wasted CI runtime.

(cherry picked from commit 6605685)
  • Loading branch information
WillemKauf authored and vbotbuildovich committed Sep 18, 2024
1 parent 2ee60c6 commit bddeec8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/rptest/tests/cluster_self_config_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@
# by the Apache License, Version 2.0
import re

from ducktape.mark import parametrize, matrix, ok_to_fail_fips
from ducktape.mark import parametrize, matrix

from rptest.services.admin import Admin
from rptest.services.cluster import cluster
from rptest.services.redpanda import CloudStorageType, SISettings, get_cloud_storage_type
from rptest.tests.end_to_end import EndToEndTest
from rptest.services.utils import LogSearchLocal
from rptest.utils.mode_checks import skip_fips_mode


class ClusterSelfConfigTest(EndToEndTest):
Expand Down Expand Up @@ -87,7 +88,7 @@ def test_s3_self_config(self, cloud_storage_type):
assert self_config_result and self_config_result in self_config_expected_results

# OCI only supports path-style requests, fips mode will always fail.
@ok_to_fail_fips
@skip_fips_mode
@cluster(num_nodes=1)
@matrix(cloud_storage_type=get_cloud_storage_type(
applies_only_on=[CloudStorageType.S3]))
Expand Down

0 comments on commit bddeec8

Please sign in to comment.