Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add alias for version in rpk #10561

Merged
merged 1 commit into from
May 10, 2023
Merged

add alias for version in rpk #10561

merged 1 commit into from
May 10, 2023

Conversation

gene-redpanda
Copy link
Contributor

@gene-redpanda gene-redpanda commented May 4, 2023 •
edited by twmb
Loading

Adds an alias for version as a convenience for people used to --version.

Fixes #4802

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

Features

  • none

Improvements

  • adds --version flag to the top level rpk command to print the rpk version

@CLAassistant
Copy link

CLAassistant commented May 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gene-redpanda gene-redpanda marked this pull request as ready for review May 4, 2023 18:31
@gene-redpanda
Copy link
Contributor Author

Screenshot 2023-05-04 at 2 31 34 PM

twmb
twmb reviewed May 5, 2023
View reviewed changes
src/go/rpk/pkg/cli/root.go Outdated Show resolved Hide resolved
@gene-redpanda
adds rpk version to cobra's Version field
bd5da04 
Setting this field enables use of --version without clobbering version or doing other weird stuff.
@gene-redpanda
Copy link
Contributor Author

gene-redpanda commented May 10, 2023 •
edited
Loading

unrelated failure https://ci-artifacts.dev.vectorized.cloud/redpanda/28652/0187ec89-0465-48c8-bbee-6bfd19b9a86e/vbuild/ducktape/results/2023-05-05--001/NodesDecommissioningTest/test_flipping_decommission_recommission/node_is_alive=True/95/report.txt is #10283

@twmb twmb merged commit bf8cbfa into dev May 10, 2023
@twmb twmb deleted the rpk-version-alias branch May 10, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expand rpk version, add rpk --version
3 participants
@gene-redpanda @CLAassistant @twmb