Fix txn consume group issues leading to undefined behavior #11110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
previously approved these changes
May 31, 2023
dotnwat
reviewed
Jun 2, 2023
An execution of abort_old_txes could span multiple terms so the so the method could modify new state assuming it's the old state resulting in undefined behavior
Make group accept term to reduce scope of where reset_tx_state is used to easier track where the write lock is necessary
When the consumer group log's term change we replay the whole log to reconstruct the state. We used to merge current and the replayed state but it's error prone. Reseting the whole txn state to have more deter- ministic behavior
rystsov
force-pushed
the
issue-10588
branch
2 times, most recently
from
0eb9b84 to
3d7d933
Compare
dotnwat
previously approved these changes
Jun 8, 2023
Transactions in kafka protocol are stateful: the processing of the requests depends on the previous commands executed by the same or even different producer. It makes the situations when the replica- tion fails with the indecisive errors such as timeout dangerous because the true state is unknown. Stepping down to resolve uncertainty by replaying the log
|
Known ci-failures:
New ci-failures (both tests don't use transactions so they don't look like related to this PR. Also checked the test result db and 11306 failed before): |
dotnwat
approved these changes
Jun 9, 2023
|
/backport v23.1.x |
|
/backport v22.3.x |
7 tasks
rystsov
added a commit
to rystsov/redpanda
that referenced
this pull request
Jun 16, 2023
This reverts commit 7ca5707. PR redpanda-data#11110 is correlated with new ci-failures. Rolling it back. Fixes: - redpanda-data#11372 - redpanda-data#11452 - redpanda-data#11344
rystsov
added a commit
to rystsov/redpanda
that referenced
this pull request
Jun 16, 2023
This reverts commit 7ca5707. PR redpanda-data#11110 is correlated with new ci-failures. Rolling it back. Fixes: - redpanda-data#11372 - redpanda-data#11452 - redpanda-data#11344
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues found during #10588 investigation. It isn't clear yet if they were causing #10588 but it looks like they might.
Backports Required
Release Notes