schema_registry: Switch Schema ID Validation enablement to cluster config #11284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenPope
added
area/redpanda
area/schema-registry
BenPope
force-pushed
the
server-side-schema-id-validation-global-config
branch
2 times, most recently
from
ffd3ba8 to
0a39d9a
Compare
NyaliaLui
reviewed
Jun 9, 2023
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
The configuration globally enables or disables Schema ID validation. Signed-off-by: Ben Pope <ben@redpanda.com>
Instead of using a feature for enabling and disabling Schema ID Validation, use the cluster configuration parameter `enable_schema_id_validation`. Disable some testing, since the feture is no longer on by default. Additional property testing will be added in a later commit. Signed-off-by: Ben Pope <ben@redpanda.com>
Schema ID validation is now enabled with cluster config: `enable_schema_id_validation` Closes redpanda-data#11113 Signed-off-by: Ben Pope <ben@redpanda.com>
Pure refactor: Move the `_compat` topic properties first to make the next refactor simpler. Signed-off-by: Ben Pope <ben@redpanda.com>
`schema_id_validation_mode::redpanda` is a subset of `compat`, that does not allow the compat topic properties in topic `create`, `alter`, and `incremental_alter`, and doesn't show them during `describe`. Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Simplify the tests by extracting out _get_topic_properties. Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
server-side-schema-id-validation-global-config
branch
from
0a39d9a to
59a3f88
Compare
NyaliaLui
reviewed
Jun 13, 2023
NyaliaLui
approved these changes
Jun 13, 2023
|
@BenPope : maybe this needs a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10650 introduced schema ID validation gated behind a feature that was enabled by default.
Instead, gate it on cluster configuration, that is disabled by default. E.g.:
There are three possible configuration options:
none: feature is disabled, checking will not occur, associated topic properties cannot be modifiedredpanda: Feature is enabled, redpanda topic properties are acceptedcompat: Feature is enabled, redpanda and compatible topic properties are acceptedCloses #11113
Backports Required
Release Notes