schema_registry: Schema ID Validation low-level tests #11297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests as an exposition of the utility Signed-off-by: Ben Pope <ben@redpanda.com>
Add a test for exposition of setting and removing schema_id_validation topic proprties. Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
server-side-schema-id-validation-remove-config
branch
from
ab185ed to
3bf5b59
Compare
michael-redpanda
approved these changes
Jun 9, 2023
|
|
||
| BOOST_AUTO_TEST_CASE(parse_and_set_optional_bool_alpha_test_remove) { | ||
| using namespace kafka; | ||
| cluster::property_update<std::optional<bool>> property; |
There was a problem hiding this comment.
nit: maybe set property to a value and ensure it doesn't change?
There was a problem hiding this comment.
That's what it does, but not part of the contract of what it should do. IMO that would be over-testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests as an exposition of setting and removing schema id validation properties.
Fixes #11115
Backports Required
Release Notes