Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_decommissioning_test: fix order of throttle and decommission #11471

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Jun 16, 2023

If we throttle after we issue the decom command, decom can finish before the throttling will take effect. The correct order (if we want the partition movements to get stuck) is throttle-then-decom.

Fixes #11365

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

If we throttle after we issue the decom command, decom can finish before
the throttling will take effect. The correct order (if we want the
partition movements to get stuck) is throttle-then-decom.
@ztlpn ztlpn requested review from bharathv and mmaslankaprv June 16, 2023 00:09
@mmaslankaprv mmaslankaprv merged commit 3eac9a5 into redpanda-data:dev Jun 16, 2023
@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v22.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants