[v23.2.x] archival: Use explicit types to encode upload candidate creation result #16099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New types are added to track failures during candidate creation. An upload candidate creation can result in three outcomes: * The candidate is created successfully * The candidate creation fails, and the offsets inspected should be skipped. * The candidate creation fails, and the offsets should be retried. The result is modeled as a sum type with these variants. An error is added to be able to log in the second and third cases. (cherry picked from commit 5cc166e)
Utilities for extracting candidate creation result and asserting types are added. (cherry picked from commit d3eeae6)
The ntp archiver relies on tools in archival policy to create upload candidates. These are modified to return errors during candidate creation explicitly, instead of inferring that creation failed from upload candidate members. It is possible to further propagate the type up the call chain so that we do not use empty upload candidates when waiting for uploads to finish, but this can be addressed in a different changeset. (cherry picked from commit 2512d4e)
abhijat
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15089