Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] CDT: fix rpk tune list test in GCP. #16367

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[v23.3.x] CDT: fix rpk tune list test in GCP. #16367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/rptest/tests/rpk_tuner_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ def test_tune_list(self):
# either x86-64 or i386.
is_not_x86 = "86" not in uname

r = str(node.account.ssh_output("dmidecode -s system-product-name"))
isGCP = "Google Compute Engine" in r

# Clocksource is only available for x86 architectures.
expected = expected.replace(
"clocksource true true ",
Expand All @@ -98,10 +101,11 @@ def test_tune_list(self):

expected = expected.replace(
"disk_write_cache true false Disk write cache tuner is only supported in GCP",
"disk_write_cache true true ") if os.environ.get(
'CDT_CLOUD_PROVIDER', None) == 'gcp' else expected
"disk_write_cache true true "
) if isGCP else expected

output = rpk.tune("list")
self.logger.debug(output)
if output != expected:
self.logger.debug(f"expected:\n{expected}\ngot:\n{output}")

assert output == expected
Loading