[v23.3.x] Improved handling of truncation with ACKS=1 #16522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit ec7b6ed)
If an offset was already visible a follower must not be allowed to truncate it as it may lead to a situation in which an offset is visible and not readable. Visible batches has the same replication guarantees as committed batches as leader still waits for the majority to acknowledge message at given offset before making it visible to the readers. This makes it possible not to truncate offsets which were previously visible. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 3d9a794)
Added test checking if an offset that is visible on the leader is not truncated on the followers. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 8975291)
mmaslankaprv
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16475