Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rptest: Fix throttling test #17474

Merged
merged 1 commit into from
Mar 29, 2024
+1 −12
Merged

rptest: Fix throttling test #17474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions tests/rptest/tests/e2e_shadow_indexing_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,7 @@ class EndToEndThrottlingTest(RedpandaTest):
def __init__(self, test_context):
self.si_settings = SISettings(
test_context,
log_segment_size=1024,
log_segment_size=1024 * 1024,
fast_uploads=True,
# Set small throughput limit to trigger throttling
cloud_storage_max_throughput_per_shard=8 * 1024 * 1024)
Expand Down Expand Up @@ -1388,17 +1388,6 @@ def test_throttling(self, cloud_storage_type):
self.logger.info("Start consumer")
self.consume()

self.logger.info("Stop nodes")
for node in self.redpanda.nodes:
self.redpanda.stop_node(node, timeout=120)

self.logger.info("Start nodes")
for node in self.redpanda.nodes:
self.redpanda.start_node(node, timeout=120)

self.logger.info("Restart consumer")
self.consume()
Comment on lines -1391 to -1400
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This makes me wonder why we restarted in the first place 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh not sure. probably copy/paste


times_throttled = self.get_throttling_metric()
self.logger.info(f"Consumer was throttled {times_throttled} times")
assert times_throttled > 0, f"Expected consumer to be throttled, metric value: {times_throttled}"
Expand Down
Loading