Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-2831] schema_registry: Allow deleted=true for post_subject #18391

Merged
merged 1 commit into from
May 13, 2024
Merged

[CORE-2831] schema_registry: Allow deleted=true for post_subject #18391

merged 1 commit into from
May 13, 2024

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented May 10, 2024 •
edited
Loading

Support deleted=true query parameter on POST /subjects/<subject>.

This allows looking up a schema against a subject even if it has been soft deleted.

Changes required for docs should be covered in: https://github.com/redpanda-data/redpanda/pull/18391/files#diff-81596000d1f82589ceb4f5793d19a3a325a5070470ddf9b3c5beb745695d78f6

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Features

  • Schema Registry: Support for deleted=true query parameter on POST /subjects/<subject>.

@BenPope
schema_registry: Support deleted=true for POST /subjects/<subject>
e881a8e 
This allows looking up a schema against a subject even if it has been soft deleted.

Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label May 10, 2024
@BenPope BenPope requested a review from a team May 10, 2024 12:07
@BenPope BenPope self-assigned this May 10, 2024
@BenPope BenPope requested review from oleiman and pgellert and removed request for a team May 10, 2024 12:07
oleiman
oleiman approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BenPope
Copy link
Member Author

BenPope commented May 13, 2024

CI Failure is known:

@michael-redpanda michael-redpanda merged commit 334220b into redpanda-data:dev May 13, 2024
18 of 21 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

This was referenced May 13, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgellert pgellert pgellert approved these changes

@oleiman oleiman oleiman approved these changes

Assignees

@BenPope BenPope

Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenPope @vbotbuildovich @oleiman @pgellert @michael-redpanda