schema_registry: Make mode_mutability: true by default #18635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@redpanda.com>
michael-redpanda
approved these changes
May 22, 2024
oleiman
approved these changes
May 22, 2024
BenPope
commented
May 22, 2024
| @@ -32,7 +32,7 @@ configuration::configuration() | |||
| {}, | |||
| {}, | |||
| config::endpoint_tls_config::validate_many) | |||
| , mode_mutability(*this, "mode_mutability", "Allow modifying mode", {}, false) | |||
| , mode_mutability(*this, "mode_mutability", "Allow modifying mode", {}, true) | |||
There was a problem hiding this comment.
We don't do this for node config as it currently isn't exported, but the properties automation script might benefit from it:
Suggested change
| , mode_mutability(*this, "mode_mutability", "Allow modifying mode", {}, true) | |
| , mode_mutability( | |
| *this, | |
| "mode_mutability", | |
| "Allow modifying mode", | |
| {.visibility = config::visibility::tunable}, | |
| true) |
|
/backport v24.1.x |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema_registry: Make mode_mutability: true by default
Backports Required
Release Notes