Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] [CORE-2845]: Ensure create_acls requests return an error when resources as topics are non valid kafka topic names #19791

Merged
merged 4 commits into from
Jun 12, 2024
Merged

[v23.3.x] [CORE-2845]: Ensure create_acls requests return an error when resources as topics are non valid kafka topic names #19791

merged 4 commits into from
Jun 12, 2024

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Jun 11, 2024 •
edited
Loading

Backport of PR #18701

Fixes #18770

oleiman and others added 4 commits June 11, 2024 16:32
@oleiman
dt/rpk: Add sasl_deny_principal
7838cfd 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 9dc1faf)
@oleiman
kafka: Return error invalid kafka topic acl
09ffa08 
- This change returns an error in the create_acls command in the case
the user attempts to create an ACL where the resource type is topic and
the topic is not a valid kafka topic.

- Fixes: https://redpandadata.atlassian.net/browse/CORE-2845

(cherry picked from commit 71d91e6)
@oleiman
rptest/clients: Add return to sasl* methods
a662e1f 
(cherry picked from commit a763ffc)
@oleiman
rptest/tests: Test bad acl kafka topic resource
a3fa6a9 
(cherry picked from commit 389e3b5)
@oleiman oleiman added this to the v23.3.x-next milestone Jun 11, 2024
@oleiman oleiman added the kind/backport PRs targeting a stable branch label Jun 11, 2024
@oleiman oleiman self-assigned this Jun 11, 2024
@oleiman
Copy link
Member Author

oleiman commented Jun 11, 2024

Changes from original:

  • Included 7838cfd to get the latest rpk functions
  • removed changes to (invalid for v23.x) allow/deny role rpk functions from a662e1f

@oleiman oleiman marked this pull request as ready for review June 11, 2024 23:36
@oleiman
Copy link
Member Author

oleiman commented Jun 12, 2024 •
edited
Loading

CI Failure:

  • rptest.tests.cloud_storage_chunk_read_path_test.CloudStorageChunkReadTest.test_read_chunks build
    • I don't see an issue for this specific symptom, but this is a release branch and the failure looks unrelated to this change

@michael-redpanda michael-redpanda merged commit a5260d3 into redpanda-data:v23.3.x Jun 12, 2024
15 of 19 checks passed
@BenPope BenPope modified the milestones: v23.3.x-next, v23.3.17 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andijcr andijcr andijcr approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

Assignees

@oleiman oleiman

Labels
kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.17
Development

Successfully merging this pull request may close these issues.
4 participants
@oleiman @andijcr @BenPope @michael-redpanda