[backport] [v24.1.x] lw heartbeats during inflight appends #20801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the upcoming change, we don't necessarily suppress hearbeats if appends are in flight, so the current naming schema may confuse the readers. No logical changes. (cherry picked from commit 5fde255)
If the inflight appends are stuck, we donot want the leader to mistakenly step down with majority heartbeat loss. Instead this commit switches to using lw heartbeats in that window. (cherry picked from commit 6619817)
Simulates stuck append entries which supress heartbeats resulting in a leader step down. (cherry picked from commit 4e92622)
ztlpn
approved these changes
Jul 1, 2024
|
@bharathv I think the release note could be a bit improved: https://github.com/redpanda-data/redpanda/releases/tag/untagged-e8ce2cd9a5a987a31e3f |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are appends in flight and are stuck (eg: disk pressure on the follower), that may result in a spurious leadership step down due to heartbeat loss as the hbs are suppressed for the duration of the append. This commit switches to using lw heartbeats when there are inflight appends to avoid this scenario.
Fixes #20591
Backports Required
Release Notes
Bug Fixes