Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin: remove throw on unknown self test type in admin_server #21370

Merged
merged 5 commits into from
Aug 2, 2024
Merged

admin: remove throw on unknown self test type in admin_server #21370

merged 5 commits into from
Aug 2, 2024

Commits on Jul 30, 2024

  1. cluster/self_test: add unknown_check 

    For logging purposes, when an unrecognized test type is requested
through the `self_test_start_handler`, it will be abstracted by
the `unknown_check` struct.
    @WillemKauf
    WillemKauf committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    aa93f3f View commit details
    Browse the repository at this point in the history

  2. cluster/self_test: use unknown_checks in backend/frontend

    @WillemKauf
    WillemKauf committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    93b1901 View commit details
    Browse the repository at this point in the history

  3. redpanda/admin: remove throw statement in start_handler 

    This commit removes the `throw` statement in
`admin_server::self_test_start_handler()` and replaces it instead
with a `push_back()` to `self_test_request::unknown_checks`.

Eventually, these unknown checks will have a result displayed
when `rpk cluster self-test status` is invoked.

For the self-test, any unrecognized tests will be appended to
`start_test_request::unknown_checks`, so a future result from
`rpk cluster self-test status` will return a message indicating
an unknown test was skipped.
    @WillemKauf
    WillemKauf committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4e99539 View commit details
    Browse the repository at this point in the history

  4. rptest: add test_self_test_unknown_test_type 

    For testing of the previous change in which unknown test types
are added to `start_test_request::unknown_checks`, instead of
resulting in a `throw`.
    @WillemKauf
    WillemKauf committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3bac4dc View commit details
    Browse the repository at this point in the history

  5. cluster/self_test: add test_type to cloudcheck cases 

    `test_type` was not being set in early exit cases for `cloudcheck`.
This would result in longer than expected output (with `IOPS`,
`THROUGHPUT`, `LATENCY` in `rpk cluster self-test status`).
    @WillemKauf
    WillemKauf committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    147d5e9 View commit details
    Browse the repository at this point in the history