[v24.1.x] storage: plumb abort source to compaction copy reducer #21422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen that during compaction, the step that reads a segment and deduplicates each record can take a long time. During this span, we do not check the compaction abort source, and this can result in compactions blocking partition shutdown. This commit plumbs the compaction abort source into the copy reducer and uses it for both self compaction and windowed compaction. (cherry picked from commit 000ff71)
piyushredpanda
approved these changes
Jul 18, 2024
|
Known failures; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21366
Fixes: #21421,