cst/cache: fix in mem trim termination condition #21606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of an in-memory trim if the size to delete is equal to or less than undeletable bytes the trim should finish, because further trimming will not result in extra space being freed up.
abhijat
force-pushed
the
issue/fix-in-mem-trim-termination-condition
branch
from
98209a9 to
1fe047d
Compare
Lazin
approved these changes
Jul 24, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of an in-memory trim if the size to delete is equal to or less than undeletable bytes the trim should finish, because further trimming will not result in extra space being freed up. The undeletable bytes are from the access tracker size.
In particular where tracker is not yet saved to disk, the size to delete and undeletable bytes can both be zero and the existing
0 < 0check fails, resulting in an expensive disk based walk being wasted as the subsequent trim runs with 0 size to delete.Backports Required
Release Notes