Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: add rpk registry mode command #22675

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Jul 31, 2024

This PR adds the new rpk registry mode command

Fixes https://github.com/redpanda-data/devex/issues/29

Examples

Set a mode

$ rpk registry mode set foo bar --mode READWRITE        
SUBJECT  MODE      ERROR
foo      READWRITE  
bar      READWRITE  

Set the global mode

$ rpk registry mode set --mode READONLY 
SUBJECT   MODE      ERROR
{GLOBAL}  READONLY  

Get the mode of foo, bar, and the global mode

$ rpk registry mode get foo bar --global
SUBJECT   MODE       ERROR
foo       READWRITE
bar       READWRITE  
{GLOBAL}  READONLY  

All new commands include support for the --format flag.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Features

  • rpk: Add rpk registry mode to manage the schema registry mode.

gene-redpanda
gene-redpanda previously approved these changes Jul 31, 2024
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r-vasquez
Copy link
Contributor Author

Force Push:

  • Add ?defaultToGlobal query param to the Get command
  • Add reset test in ducktape

gene-redpanda
gene-redpanda previously approved these changes Aug 1, 2024
@Deflaimun
Copy link
Contributor

The global operation seems a bit error prune. The user might just forget to pass a subject and end up changing the mode globally without knowing.

Should we gate this behind a confirmation, or modify the global operation to work with a flag --global ?

New command that let users modify the
schema registry mode with rpk.
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Aug 1, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/52370#01910f9b-111b-492f-affb-5f00f4b25ad3:

"rptest.tests.controller_snapshot_test.ControllerSnapshotPolicyTest.test_snapshotting_policy"

new failures in https://buildkite.com/redpanda/redpanda/builds/52370#01910f9b-1120-467b-8d3f-55b314274b1d:

"rptest.tests.e2e_iam_role_test.ShortLivedCredentialsTests.test_short_lived_credentials"

@twmb twmb merged commit 459d20e into redpanda-data:dev Aug 2, 2024
23 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants